Repository navigation
Add common films endpoint - #5
Merged
Merged
Conversation
Kirill-Kazantcev
approved these changes
Oct 7, 2026
Kirill-Kazantcev
left a comment
Kirill-Kazantcev
left a comment
Collaborator
There was a problem hiding this comment.
Регрессии нет, тесты зелёные.
LIMIT в отдельную константу т.к не используется findCommon - ОК
Roman32-gif
approved these changes
Oct 8, 2026
This was referenced Oct 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /films/common?userId={userId}&friendId={friendId} — фильмы, которые лайкнули оба пользователя, по убыванию популярности. Если кого-то из пользователей нет — 404.
Заодно вынесла LIMIT из хвоста запроса популярных: buildPopularQuery теперь собирает чтение + условия + сортировку по лайкам без лимита, его можно переиспользовать в поиске и фильмах режиссёра.
В findPopular лимит добавляется отдельно, поведение не изменилось.