Skip to content

docs: Some micro fixes #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krutoo merged 1 commit into from
Sep 3, 2026
Merged

docs: Some micro fixes #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/docs/react/dom/portal.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function App() {
<button onClick={() => setModalOpen(true)}>Show modal</button>

{/* By default portal will render content to new div in end of body */}
{open && (
{modalOpen && (
<Portal>
<div className='my-modal'>Hello, from modal!</div>
</Portal>
Expand All @@ -50,7 +50,7 @@ function App() {
<>
<button onClick={() => setModalOpen(true)}>Show modal</button>

{open && (
{modalOpen && (
<Portal container={document.querySelector('#portal')}>
<div className='my-modal'>Hello, from modal!</div>
</Portal>
Expand Down Expand Up @@ -79,7 +79,7 @@ function App() {
<>
<button onClick={() => setModalOpen(true)}>Show modal</button>

{open && (
{modalOpen && (
<Portal container={document.querySelector('#root')} connect={false}>
<div className='my-modal'>Hello, from modal!</div>
</Portal>
Expand Down Expand Up @@ -108,7 +108,7 @@ function App() {
<>
<button onClick={() => setModalOpen(true)}>Show modal</button>

{open && (
{modalOpen && (
<Portal container={document.querySelector('#root')} cleanup={false}>
<div className='my-modal'>Hello, from modal!</div>
</Portal>
Expand Down
8 changes: 3 additions & 5 deletions docs/docs/rspack/node-externals.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ export default {
mode: 'development',
target: 'node',
output: {
filename: 'index.js'
}
filename: 'index.js',
},
externalsPresets: {
node: true,
},
externals: [
nodeExternals(),
],
externals: [nodeExternals()],
};
```

Expand Down
Loading