Repository navigation
French language and File age stats feature - #2
Merged
Merged
Conversation
Rework of the PR kreotropic#2 frontend: drop chart.js/vue-chartjs and the tab bar, draw the five age buckets as SVG bars in the lower pane, switched from a compact Map | File age toggle in the header. The panel follows the folder selected in the tree and the category filter. Backend kept, reformatting reverted, comments cleaned up.
Draw the per-bucket share as an SVG donut in the free space right of the bars, centred on the bar block; hidden on panes narrower than 560px. Scope the toggle's item rules under .dm-segmented so core's button margin no longer leaves a gap around the active segment.
Rows now split the pane's height evenly instead of being capped at 52px, the donut follows the bar block's height, and label/value/total text sizes follow the space available.
Owner
|
Hi @DidierSardine, thanks a lot for this PR. The French translation and the file-age idea are both great, and the backend ( I pushed a few commits on top of your branch to rework the frontend. The two things I wanted to change were screen space and bundle size: Layout
Chart
Behaviour
Backend / l10n
Could you have a look and tell me if this works for you? If you're happy with it, I'll merge. |
Contributor
Author
|
That's great, I'm satisfied with the changes, you can merge, thanks a lot ! |
Owner
|
Done! Not planning a release right away but I'll try to release this month! Thanks |
Owner
|
Hi! v0.5.0 is live in the store with the changes you made! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
The File Age Viewer chart is implemented in a tab alongside the Treemap.
You can view the age stats by file count or file size, using an histogram or a pie chart to see the percentage breakdown.
This feature is available across all storage types, just like DiskMap: user folders, team folders, external storage, and the entire instance.