Add negotiate parameter to wrap_socket (fixes #175) - #195
Merged
Conversation
The chat example was broken because both client and server were sending negotiation cells when both specified regexes. Changes: - Add negotiate=True parameter to wrap_socket() - When negotiate=False, skip negotiation and set up encoders immediately - Update chat examples to use negotiate=False - Add test for negotiate=False functionality This allows symmetric use cases where both sides know the formats upfront, while maintaining backwards compatibility with the relay use case (negotiate=True is the default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat example was broken because both client and server were sending negotiation cells when both specified regexes.
Changes:
This allows symmetric use cases where both sides know the formats upfront, while maintaining backwards compatibility with the relay use case (negotiate=True is the default).