Repository navigation
fix: remove the mcp capability - #4
Merged
Merged
Conversation
pages calling the viewer's MCP servers live isn't part of the plugin's focus (3d mockups and comment-driven edits), and
expanding ${VAR} into those servers' configs read credentials from the environment. drops mcphost.ts, the daemon's
mcp routes and approvals, the viewer's consent and confirm prompts for it, and its runtime, docs and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the last "Uses a credential from the user's machine" finding:
server/mcphost.tsexpanded${VAR}references from the environment into MCP server configs.The
mcpcapability let a published page call the viewer's local MCP servers live (self-refreshing dashboards). It's outside the plugin's focus, 3D mockups and comment-driven edits, so it's removed entirely:server/mcphost.ts, the daemon's/_frame/api/mcp/*routes and one-time approvalsmcphandling,caps.js'smcpnamespacemcpfrom the capability roster and grants; the skill, prompts and README no longer mention itmcp-notes.mjsfixtureClaude's own MCP tools in the session are unaffected. Comments, monitors, 3D scenes,
db,filesandroomare unchanged.Smoke test
capabilities: { mcp: {} }→ publish is refused withunknown capability "mcp".files, open the permissions shield → it lists "Read project files" only.