Repository navigation
fix: move tests out of the shipped plugin and reword a db error - #3
Merged
Merged
Conversation
- tests live in test/ at the repo root, so the directory validator no longer scans them as plugin code
- the db error 'unknown op ${op}' read as a credential-store command; now 'unknown write operation'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the remaining "Uses a credential from the user's machine" findings from the directory validator.
plugins/spatial-artifacts/test/totest/at the repo root, so they aren't shipped with the plugin or scanned as plugin code. Rootlint,typecheckandtestscripts cover them (rooteslint.config.jsre-exports the plugin's config,test/tsconfig.jsonextendstsconfig.src.json).server/db.ts: the errorunknown op ${w.op}read as a credential-store command (opis 1Password's CLI); nowunknown write operation "…".Smoke test
test/directory.unknown write operation "…".