Repository navigation
fix: remove sample capability and credential reads for directory review - #1
Merged
Merged
Conversation
- drop the sample capability, which read ANTHROPIC_API_KEY / ANTHROPIC_AUTH_TOKEN - stop reading ~/.claude.json for the mcp capability; servers come from the project's .mcp.json or ~/.spatial-artifacts/mcp.json - use a reserved .invalid host in cross-origin tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the directory validator's "Uses a credential from the user's machine" hold.
samplecapability (pages asking Claude via the Anthropic API), which readANTHROPIC_API_KEY/ANTHROPIC_AUTH_TOKEN. Comments and the session monitor are unaffected.mcpcapability no longer reads~/.claude.json; servers come from the project's.mcp.jsonor~/.spatial-artifacts/mcp.json.evil.invalidinstead ofevil.com.Smoke test
capabilities: { sample: {} }→ publish is refused withunknown capability "sample".comments, leave a comment and send it to Claude → the session's monitor picks it up as before.mcpnaming a server from the project's.mcp.json→ the consent dialog lists it andcallToolworks.files→ no "Ask Claude" entry appears.