feat: add s390x support to install-cli.sh#936
Conversation
Map the s390x machine type to the s390x release asset so the install script works on linux/s390x hosts. The linux/s390x build target was added in 4acd31e but install-cli.sh still rejected the architecture.
|
Claude finished @dangrondahl's task in 1m 33s —— View job Review of PR #936: feat: add s390x support to install-cli.sh
Static AnalysisAll checks pass:
(Expected since this PR only touches a shell script, but good to confirm nothing else drifted.) Code ReviewThis PR looks good to merge. The change is minimal, correct, and follows the existing patterns exactly. What it does right:
No issues found — no bugs, no edge cases missed, no security concerns. The |
|
Tested install of v2.24.2 across all release targets:
Darwin/Windows aren't containerisable on macOS, but this patch only touches the Linux arch-detection branch, so the other OS paths are unchanged from |
|
Note: I considered adding s390x coverage to |
Summary
s390xmachine type to thes390xrelease asset ininstall-cli.shThe
linux/s390xbuild target was added in 4acd31e, but the install script still rejected the architecture, forcing s390x users to download the tarball manually.Test plan
install-cli.shon a linux/s390x host and verify it downloadskosli_<version>_linux_s390x.tar.gzand installs successfully