Skip to content

Why react-document-meta instead of react-helmet? #22

Description

@danilobuerger

See title :-)

Activity

  1. danieljuhl commented on Apr 18, 2016

    @danieljuhl
    Contributor

    Firstly, because it uses another logic for merging, and secondly, because react-document-meta existed before react-helmet 😃

  2. danilobuerger commented on Apr 18, 2016

    @danilobuerger
    Author
    1. react-helmet seems to be able to render more attributes, are you planning on expanding those?
    2. would you mind giving a short explanation on how merging differs?
  3. danieljuhl commented on Apr 18, 2016

    @danieljuhl
    Contributor

    They are actually related... yes, we have a plan and we are working on expanding to allow (almost) any meta tags.

    react-helmet gives you the ability to add an array, but that limits the ability to merge nested data, because the code does not know which ones to keep (unchanged), which to change and which to delete. So you actually end up with limited control of the actual meta tags rendered.

    We are working on an implementation much like react-helmet, but we are aiming at one, that solves to merging issue.

  4. danilobuerger commented on Apr 18, 2016

    @danilobuerger
    Author

    What i dislike about react-helmet, and thus looking for alternatives, is that you can't render children with it and you always end up with:

    <div>
      <Helmet />
      {children}
    </div>
    

    instead of

    <Helmet>{children}</Helmet>
    

    which is possible with react-document-meta as far as i skimmed over the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions