Repository navigation
Conversation
|
Thanks for fix! Env: Windows, Python 3.13, anywidget 0.11.0 ipywidgets 8.1.9, VS Code Extension Jupyter 2025.9.1 and Jupyter Lab 4.3.5 on Waterfox |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40, reported by @Artur-Minorius.
The first drag can draw points without updating
widget.data, leavingdata_as_pandasempty until a later click. The local drawing array aliases the widget model's array, so appending points changes the model value beforemodel.setcan detect a change. Drawing after a Python-side data replacement has the same problem.Copy the array when initializing local drawing state and when receiving
change:data. Pending points then stay local until the batch is published. Rebuild the checked-in JavaScript bundle with the repository's pinned esbuild 0.19.11.Add real JupyterLab/browser regressions for initially empty data, constructor-provided data, and Python-side data replacement.
Validation on Windows, Python 3.12, JupyterLab 4.6.4, anywidget 0.11.0, ipywidgets 8.1.9 and headless Microsoft Edge:
Browser tests require
pytest-playwrightandjupyterlabas described in the test module; runtime dependencies are unchanged. Other notebook hosts, operating systems and Python versions were not tested.