Skip to content

Replace @knocklabs/client axios transport with fetch #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjbell wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Replace @knocklabs/client axios transport with fetch #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c5e434b
Replace client axios transport with fetch
cursoragent Jun 5, 2026
6623b81
Fix fetch transport type compatibility
cursoragent Jun 5, 2026
5dafb6d
Harden fetch client edge cases
cursoragent Jun 5, 2026
162283c
test(client): add characterization tests for fetch transport
kylemcd Jun 18, 2026
aee13fd
refactor(client): apply TS conventions to api.ts (ApiResponse type al…
kylemcd Jun 18, 2026
915dfbb
fix(client): drain retry response body directly instead of cloning
kylemcd Jun 18, 2026
3ef433d
fix(react-core): detect unconnected Slack/MS Teams via response statu…
kylemcd Jun 18, 2026
84ac998
fix(client): honor Retry-After header and restore retry jitter
kylemcd Jun 18, 2026
eb1b42b
chore: add changeset for the react-core connection-status fix
kylemcd Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/react-core-connection-status.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@knocklabs/react-core": patch
---

Keep Slack and MS Teams connection-status detection working with the new fetch-based `@knocklabs/client` transport by reading the HTTP response status instead of the previous axios-specific error `code`. The exported `AuthCheckResult` type no longer includes `code` and now exposes `response.status`.
5 changes: 5 additions & 0 deletions .changeset/remove-client-axios.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@knocklabs/client": patch
---

Replace the internal axios transport with native fetch and remove axios dependencies.
2 changes: 0 additions & 2 deletions packages/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@
"@knocklabs/types": "workspace:^",
"@tanstack/store": "^0.7.2",
"@types/phoenix": "^1.6.7",
"axios": "^1.15.1",
"axios-retry": "^4.5.0",
"eventemitter2": "^6.4.5",
"nanoid": "^3.3.12",
"phoenix": "1.8.5",
Expand Down
Loading
Loading