fix null pointer dereferences in intra channel and long term prediction - #234
Merged
Conversation
Ensure "pred_stat" is not null in reconstruct_channel_pair(), similar to the check in reconstruct_single_channel().
Like ic_prediction(), lt_prediction() expects a "pred_stat" parameter which is not null. Add checks to ensure that and add a new error message.
Contributor
Author
|
@fabiangreffrath: Do you already have an idea when faad 2.11.3 will potentially be released? |
Collaborator
|
Good idea! I'll try to get something out today. |
Contributor
Author
|
Great, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have experienced random segfaults when playing AAC files from https://toolsfairy.com/audio-test/sample-aac-files with Audacious. Its AAC plugin is based on faad2 and while debugging this, I found out the underlying problems are null pointer dereferences in faad2. The two commits prevent the segfaults by appropriate null checks.