Repository navigation
fix(store): prevent TOCTOU race on event seq numbering (#98) - #110
Merged
knight22-21 merged 1 commit intoOct 22, 2026
Merged
Conversation
Owner
|
Thanks for the fix, @chiragjangiir! Resolving event sequence numbers directly within the append transaction prevents duplicate sequence numbers under concurrent event logging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98
Root Cause
In
devagent/session/store.py,append_event()read the next sequence number viaSELECT COALESCE(MAX(seq), -1) + 1and then inserted the new event. In concurrent environments (such as parallel multi-worker agent sessions), two concurrent workers could read the sameMAX(seq)simultaneously before either inserted a row. Because SQLite autocommits statements individually when no explicit transaction is begun on read, both workers generated identicalseqvalues, causing collisions in event ordering.Changes
conn.execute("BEGIN IMMEDIATE")before readingMAX(seq)inappend_event(), guaranteeing exclusive write-transaction access across the read-calculate-insert cycle.timeout=30.0to_conn()so concurrent threads wait for lock release rather than prematurely raisingsqlite3.OperationalError.tests/test_event_seq_concurrency.pyasserting that 24 concurrent threads writing to the same session simultaneously produce strictly unique, unbroken, monotonic sequence numbers (0 to 23).Verification