Repository navigation
Carry effort and extended-thinking settings into routed LLM configs - #105
Merged
knight22-21 merged 1 commit intoOct 13, 2026
Merged
Conversation
get_llm_for_task built a fresh LLMConfig without effort, extended_thinking or thinking_budget_tokens, so routed calls always used the defaults regardless of [llm] settings. Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
Owner
|
Thanks for the fix, @mayuriphad! Forwarding \effort, \extended_thinking, and \ hinking_budget_tokens\ into the routed LLM configs ensures user settings aren't silently dropped during task routing. If you find DevAgent useful, a ⭐ on the repo would mean a lot — no pressure though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_llm_for_task()built the routedLLMConfigwithouteffort,extended_thinkingorthinking_budget_tokens, so every routed call (planning, coding, reviewing, cheap) used the defaults (effort="high", thinking off) whatever the user set under[llm].config.llm.mainand passes with the change.Testing
pytest tests/test_phase5.py: 29 passed (28 passed + 1 failed without the fix).ruff checkon the changed files passes.Closes #100