[divyani-22]

Description

The config_ci tool generates GitHub Actions CI workflow files on disk, but lacked a read-only check. When the Functions MCP server operates in default read-only mode (FUNC_ENABLE_MCP_WRITE not set), executing config_ci bypassed policy and allowed writing workflow files to the local repository.

This change adds the s.readonly.Load() guard to configCIHandler, updates instructions_warning.md, and adds a corresponding unit test following the pattern established in #4116 and #3708.

Changes

• Check s.readonly.Load() at the start of configCIHandler in pkg/mcp/tools_config_ci.go.
• Document config_ci under disabled operations in pkg/mcp/instructions_warning.md.
• Add TestTool_ConfigCI_Readonly in pkg/mcp/tools_config_ci_test.go.

Testing

• TestTool_ConfigCI_Readonly verifies that config_ci returns an error in read-only mode and the executor is not invoked.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divyani-22
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: divyani-22 / name: Divyani (3785270)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

[knative-prow]

Welcome @divyani-22! It looks like this is your first PR to knative/func 🎉

[knative-prow]

Hi @divyani-22. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.