Repository navigation
Move slim-cluster registry to host port 5001 - #4119
Merged
Merged
Conversation
The slim Kafka integration cluster skips serving, so it has no Contour ingress and a host-side `func deploy` build+push cannot reach the in-cluster registry through registry.localtest.me. knative#4111 exposed the registry by mapping host port 5000 to the node unconditionally, for every cluster hack/cluster.sh creates. On macOS the AirPlay Receiver listens on *:5000, so that unconditional mapping makes `kind create cluster` fail to bind -- breaking cluster creation for every developer on a Mac, not just the Kafka job. CI runs on Linux, so it never caught this. Map the registry to the host only on serving-less clusters (full clusters push through the ingress and need no host mapping), and use host port 5001 to dodge AirPlay. The node still serves the registry on container port 5000; a containerd mirror resolves localhost:5001 to it so pushed images -- now tagged localhost:5001 -- can be pulled. Update the Python delivery test to push to localhost:5001.
knative-prow
Bot
added
kind/bug
knative-prow
Bot
added
the
size/M
lkingland
approved these changes
Oct 30, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
hack/cluster.shto serving-less (slim) clusters only, instead of mapping it for every cluster. Full clusters push to the registry through the Contour ingress and need no host mapping.*:5000, so the previous unconditional:5000mapping madekind create clusterfail to bind — breaking cluster creation for every macOS developer, not just the Kafka job (CI runs on Linux, so it never caught this). A containerd mirror resolveslocalhost:5001to the node's registry so pushed images can still be pulled.localhost:5001/functo match./kind bug
Release Note
Docs