[Elvand-Lie]

Changes

The raw Kubernetes deployer reconstructs a corev1.Service when redeploying a function. On updates, it previously preserved only the existing Service's ResourceVersion.

Because the generated Service does not contain the network configuration allocated by Kubernetes, redeploying an existing function could submit an empty spec.clusterIP and fail with:

Service "<function-name>" is invalid: spec.clusterIP: Invalid value: "": field is immutable

This change preserves the existing Service's ClusterIP, ClusterIPs, IPFamilies, and IPFamilyPolicy before calling Update, while continuing to generate mutable fields such as ports, selectors, labels, and annotations from the function configuration.

New Service creation is unchanged, so Kubernetes continues to allocate and default its network fields.

The KEDA deployer inherits the fix because it delegates workload deployment to the raw Kubernetes deployer.

Regression tests cover IPv4 single-stack, IPv6 single-stack, dual-stack, preservation of generated mutable fields, and the initial Service creation path.

Testing

• Tests done and verified locally: unit test suites (make test), linting and repository checks (make check), and test coverage for single-stack IPv4/IPv6 and dual-stack Service network field preservation.
• Manual redeployment with func deploy --deployer=raw verified against a Kubernetes cluster, confirming existing Service ClusterIP and network configuration are preserved across updates.
• Fork CI passed the repository's precheck, unit, integration, template, Podman, and runtime E2E suites.

/kind bug

Release Note

Fixed raw and KEDA function redeployments failing when updating an existing Kubernetes Service.

Docs

NONE

[knative-prow]

Hi @Elvand-Lie. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lkingland]

Thansk for the contribution. Looks good! Just needs a rebase and we can ✅

[Elvand-Lie]

@lkingland Rebased onto the latest main and re-verified. Ready for another look.

[lkingland]

Thanks @Elvand-Lie, and thanks for the rebase.

/ok-to-test
/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elvand-Lie, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lkingland]

Rebased onto main (conflict was only appended tests in deployer_test.go; both suites kept).

/lgtm