Skip to content

mcp: createHandler lacks readonly mode guard #3810

Closed as not planned
Closed as not planned

Description

@Elvand-Lie

Description

The \createHandler\ in \pkg/mcp/tools_create.go\ lacks the \s.readonly.Load()\ check that is present in other mutating tools like \deployHandler\ and \deleteHandler.

Because of this, an MCP client can execute the \create\ command (which writes project scaffolding files to the disk) even when the server is operating in readonly mode.

Expected Behavior

The \create\ tool should check \s.readonly.Load()\ and return an error if readonly mode is enabled, matching the behavior of \deploy\ and \delete.

Activity

  1. Elvand-Lie commented on May 20, 2026

    @Elvand-Lie
    ContributorAuthor

    /kind bug

  2. added 3 commits that reference this issue on May 21, 2026
    c4cd153
    b8524f9
    86fa702
  3. added a commit that references this issue on Jun 26, 2026
    6ed4519
  4. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    This issue is stale because it has been open for 90 days with no
    activity. It will automatically close after 30 more days of
    inactivity. Reopen the issue with /reopen. Mark the issue as
    fresh by adding the comment /remove-lifecycle stale.

  5. lkingland commented on Oct 29, 2026

    @lkingland
    Member

    Withdrawn by the author in #3811: create is allowed in read-only mode by design. The remaining read-only gap (git config tools) is addressed in #4116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions