Repository navigation
fix(ui): refine card corner badges - #1299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Large macOS cards can compress unread counts into an ellipsis. Corner badges also feel too prominent on larger macOS and iOS cards, and their opaque dark slabs look heavier than intended.
Root cause
The unread count text can accept a compressed width from its overlay layout instead of retaining its intrinsic horizontal size. Badge sizes previously grew linearly with card width, overshooting the desired sizes on large cards.
Fix
Validation
make format— passed.make build— iOS, macOS, and tvOS builds all passed.