Skip to content

fix(jobs): reject empty CMAKE_PREFIX_PATH entries on Windows #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kmjtechno wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(jobs): reject empty CMAKE_PREFIX_PATH entries on Windows #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cefad27
fix(jobs): fail closed on empty CMake prefix path entries
kmjtechno Nov 9, 2026
3f67edf
test(jobs): reject leading trailing and interior empty CMake entries
kmjtechno Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jobs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export function jobEnvironment(
const value = source.CMAKE_PREFIX_PATH;
const parts =
typeof value === "string" && value.length <= 4096
? value.split(";").filter((part) => part.length > 0)
? value.split(";")
: [];
if (
parts.length > 0 &&
Expand Down
3 changes: 3 additions & 0 deletions tests/windows-job-environment.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ test("CMAKE_PREFIX_PATH is inherited only by approved cmake commands and only wh
"C:\\Qt" + String.fromCharCode(10) + "x",
"C:\\" + "a".repeat(5000),
";;",
";C:\\Qt",
"C:\\Qt;",
"C:\\Qt;;D:\\libs",
]) {
assert.equal(
Object.hasOwn(
Expand Down