Skip to content

feat: expose effective repository scan settings - #336

Merged
klboke merged 1 commit into
mainfrom
feat/security-scan-effective-settings
Sep 23, 2026
Merged

klboke merged 1 commit into
mainfrom
feat/security-scan-effective-settings

Conversation

@klboke

@klboke klboke commented Sep 23, 2026

Copy link
Copy Markdown
Owner

Summary

The Artifact Scanning repositories table now shows effective result validity and pending/failure/partial handling alongside enforcement mode. Repository format and type move into a tooltip, keeping the table at eight columns.

  • Resolve validity on the server using the same calculation as scan finalization: inherit an enabled policy's limit when the repository leaves it unset, use the shorter limit when both are set, and ignore disabled policies' age limits. Preserve the editable repository configuration.
  • Show configured exception actions with audit/inactive markers, and reflect disabled policies' partial-result bypass. Hover/focus tooltips explain the value source and download behavior, including why allowing partial results does not guarantee access.
  • Reuse the existing accessible tooltip component for dynamically rendered rows and update the English/Chinese operator guides.

Related to #331.

Validation

  • Targeted server and UI regression suite: 52 tests passed, including all eight validity combinations and the existing finalizer regressions.
  • mvn -B -ntp -pl admin-ui test (41 tests, including JavaScript suites).
  • Browser verification with local fixtures using the production renderer/styles: eight-column layout, inherited/both/no-expiry values, audit/inactive/disabled-policy rows, tooltip focus and Escape dismissal, and table refresh.
  • JavaScript syntax check and git diff --check.
  • Protocol/client/native E2E: not applicable; no protocol, client, or native configuration changes.

Compatibility and design checklist

  • No protocol behavior changes; the existing admin repository response gains additive presentation fields.
  • No compatibility-test changes needed; result finalization keeps its existing semantics and regression coverage.
  • No new persistence, cache, locking, scheduling, or permission behavior. Effective settings are computed from the existing shared database configuration reads without additional per-row queries.
  • No migration changes.

Notes for reviewers

SecurityScanResultValidity is shared by finalization and the management response to prevent UI/runtime drift. The table describes this repository's scan configuration; tooltips explicitly note that other applicable repository policies can still block downloads. No expiry is not presented as proof of a fresh or safe artifact.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T05:44:09.060474Z bbcd55f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.27%. Comparing base (d9ab6a0) to head (bbcd55f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #336   +/-   ##
=========================================
  Coverage     86.26%   86.27%           
- Complexity     1447     1448    +1     
=========================================
  Files           799      800    +1     
  Lines         83661    83668    +7     
  Branches      14690    14694    +4     
=========================================
+ Hits          72172    72183   +11     
+ Misses        11489    11485    -4     
Flag Coverage Δ
server-smoke-mysql 13.39% <0.00%> (+0.01%) ⬆️
server-smoke-postgresql 13.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@klboke
klboke merged commit bc59bf6 into main Sep 23, 2026
38 checks passed
@klboke
klboke deleted the feat/security-scan-effective-settings branch September 23, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant