fix: make scan task assets traceable in the UI - #335
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=========================================
Coverage 86.27% 86.27%
+ Complexity 1449 1448 -1
=========================================
Files 800 800
Lines 83668 83699 +31
Branches 14694 14706 +12
=========================================
+ Hits 72181 72213 +32
+ Misses 11487 11486 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77b3ac868d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Scan tasks currently expose only an internal asset ID, so operators cannot identify the artifact or open it from the task list. Add the asset path beside the ID and link it to Repository Browser, preserving group/member context and using the existing projected and Docker manifest paths.
Asset metadata is resolved in batches from shared persistence. Unresolvable or deletion-nulled asset references display “Asset unavailable”; unrelated repository assets are not resolved. Existing deletion semantics clear the asset foreign key, so this change does not preserve historical asset coordinates after deletion. Update the English/Chinese operator guides and refresh admin asset cache versions.
Related to #328.
Validation:
7382720d: CI, MySQL/PostgreSQL persistence and server smoke checks, CodeQL, and Codecov all passed. All modified coverable lines are covered; project coverage is 86.27%.Command:
mvn -B -ntp -pl server -am '-Dtest=SecurityScanManagementService*Test,SecurityScanManagementControllerTest,AdminSecurityScanningCapabilityContractTest,SecurityScanTasksJavascriptTest' -Dsurefire.failIfNoSpecifiedTests=false test