Skip to content

feat: suggest for kkdao PR with translations - #4

Open
joaozinhom wants to merge 2 commits into
kkdao:fix/fee-percent-spendfrom
joaozinhom:fee-payment-warning-pr957
Open

joaozinhom wants to merge 2 commits into
kkdao:fix/fee-percent-spendfrom
joaozinhom:fee-payment-warning-pr957

Conversation

@joaozinhom

@joaozinhom joaozinhom commented Oct 12, 2026 •

Copy link
Copy Markdown

What is this PR for?

complements: selfcustody#957

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

kkdao and others added 2 commits October 9, 2026 23:24
The high fee warning divided the fee by every output, change included,
so a payment made from a large coin hid a high fee. In the existing
test data, paying 1,000 sat and sending 1,000 sat to the wallet itself
with a 373 sat fee is 18.7% of what is sent, yet it showed 3.9% and
never warned.

Measure the warning against what is sent instead: spends plus transfers
to the wallet's own receive addresses, since the user chose to create
both. Change is the base only when nothing else is sent. The summary
still divides by all outputs, so its percentage keeps matching
coordinators like Sparrow.
@joaozinhom
joaozinhom marked this pull request as draft October 12, 2026 17:58
@joaozinhom

Copy link
Copy Markdown
Author

I’ll leave this as a draft until I finish reviewing it. I opened it now just to make the diff easier to inspect.

@joaozinhom
joaozinhom marked this pull request as ready for review November 3, 2026 14:20

@qlrd qlrd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ed33ccc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants