Repository navigation
feat: suggest for kkdao PR with translations - #4
Open
joaozinhom wants to merge 2 commits into
Open
joaozinhom wants to merge 2 commits into
joaozinhom wants to merge 2 commits into
Conversation
The high fee warning divided the fee by every output, change included, so a payment made from a large coin hid a high fee. In the existing test data, paying 1,000 sat and sending 1,000 sat to the wallet itself with a 373 sat fee is 18.7% of what is sent, yet it showed 3.9% and never warned. Measure the warning against what is sent instead: spends plus transfers to the wallet's own receive addresses, since the user chose to create both. Change is the base only when nothing else is sent. The summary still divides by all outputs, so its percentage keeps matching coordinators like Sparrow.
joaozinhom
marked this pull request as draft
October 12, 2026 17:58
Author
|
I’ll leave this as a draft until I finish reviewing it. I opened it now just to make the diff easier to inspect. |
joaozinhom
marked this pull request as ready for review
November 3, 2026 14:20
3 of 9 tasks
qlrd
approved these changes
Nov 13, 2026
3 of 9 tasks
kkdao
force-pushed
the
fix/fee-percent-spend
branch
from
November 14, 2026 16:00
da5629e to
666bc7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
complements: selfcustody#957
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?