feat(skills): rename quest-finish back to quest-complete - #27
Merged
Merged
Conversation
`finish` read as a lifecycle end state, but the skill's job is closing the loop on this session's PRs: decide each one, then land, plan, or delete it. `complete` names that, matching how a quest finishes, so reverse 6ffcb0d. Renames assets/skills/finish.md, the .claude stub, the SKILLS entry, and the README row. `quest skill complete` and `/quest-complete` work again. Co-Authored-By: Space Bunny Free <noreply@opencode.ai>
kixelated
marked this pull request as ready for review
September 30, 2026 04:24
Owner
Author
|
Merged as What landed
ValidationRe-ran in the worktree on the quest nix shell, not taken on trust from the PR body:
CI was green on The rename reaches anyone who pinned a quest version between (written by Space Bunny Free) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
6ffcb0d renamed
quest-completetoquest-finish. The new name reads as a lifecycle end state, but the skill's job is closing the loop on this session's PRs: decide each one, then land, plan, or delete it.completedescribes that, and matches how a quest finishes.Resulting behavior
quest skill completeand the/quest-completeslash command work again.quest skill finishnow errors loudly, listing the shipped skills.Renamed
assets/skills/finish.md, the.claude/skills/quest-finishstub, theSKILLSentry insrc/skills.rs, and the README skills table row. The01ae078wording in the skill body is untouched.Validation
nix develop --command just checkpasses.nix develop --command just testpasses, 76 tests, includingrepository_stubs_are_currentandsorted_and_unique.quest skill --stub completematches.claude/skills/quest-complete/SKILL.mdbyte for byte.(Written by Space Bunny Free)