Skip to content

feat(skills): rename quest-finish back to quest-complete - #27

Merged
kixelated merged 1 commit into
mainfrom
fix/rename-finish-back-to-complete
Sep 30, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/rename-finish-back-to-complete

Conversation

@kixelated

Copy link
Copy Markdown
Owner

Problem

6ffcb0d renamed quest-complete to quest-finish. The new name reads as a lifecycle end state, but the skill's job is closing the loop on this session's PRs: decide each one, then land, plan, or delete it. complete describes that, and matches how a quest finishes.

Resulting behavior

quest skill complete and the /quest-complete slash command work again. quest skill finish now errors loudly, listing the shipped skills.

Renamed assets/skills/finish.md, the .claude/skills/quest-finish stub, the SKILLS entry in src/skills.rs, and the README skills table row. The 01ae078 wording in the skill body is untouched.

Validation

  • nix develop --command just check passes.
  • nix develop --command just test passes, 76 tests, including repository_stubs_are_current and sorted_and_unique.
  • quest skill --stub complete matches .claude/skills/quest-complete/SKILL.md byte for byte.

(Written by Space Bunny Free)

`finish` read as a lifecycle end state, but the skill's job is closing the
loop on this session's PRs: decide each one, then land, plan, or delete it.
`complete` names that, matching how a quest finishes, so reverse 6ffcb0d.

Renames assets/skills/finish.md, the .claude stub, the SKILLS entry, and the
README row. `quest skill complete` and `/quest-complete` work again.

Co-Authored-By: Space Bunny Free <noreply@opencode.ai>
@kixelated
kixelated marked this pull request as ready for review September 30, 2026 04:24
@kixelated
kixelated merged commit 9384a25 into main Sep 30, 2026
7 checks passed
@kixelated

Copy link
Copy Markdown
Owner Author

Merged as 9384a25.

What landed

quest skill complete and /quest-complete are back; quest skill finish now errors loudly and lists the shipped skills. The reverse of 6ffcb0d touched four files, with assets/skills/finish.md renamed byte for byte.

Validation

Re-ran in the worktree on the quest nix shell, not taken on trust from the PR body:

  • nix develop --command just check passes: fmt, clippy -D warnings, quest check (7 documents), the examples/export tree, actionlint, shellcheck, shfmt, taplo, nixfmt.
  • nix develop --command just test passes: 76 nextest tests, doc tests, and the direnv hook regression suite.
  • repository_stubs_are_current and sorted_and_unique pass in isolation.
  • quest skill --stub complete is byte identical to .claude/skills/quest-complete/SKILL.md.
  • quest skill finish exits 1 with no skill named finish (have: audit, complete, delete, export, import, merge, plan, spawn, start).

CI was green on 71e469d1 and the branch was level with origin/main, so this squashed straight away rather than queueing auto-merge. There were no review findings to address.

The rename reaches anyone who pinned a quest version between 6ffcb0d and now; a pin upgrade moves them back. No version bump here, since the package stays publish = false until release naming is settled.

(written by Space Bunny Free)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant