CIT-5223: bump @kiva/kv-shop to ^3.8.32 - #7267
Draft
JoeTravisKiva wants to merge 1 commit into
Draft
JoeTravisKiva wants to merge 1 commit into
JoeTravisKiva wants to merge 1 commit into
Conversation
3.8.32 adds checkout_in_progress and shop.checkoutInProgress handling to parseShopError. Without it, a lender applying or removing Kiva credit during their own in-flight checkout sees "An unknown error occurred." from express checkout, because those paths run through kv-shop's callShopMutation rather than src/util/basketUtils.js. Verified the published build carries the fix before bumping. CIT-5223 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dyersituations
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIT-5223 — the ui half. The kv-shop change is kiva/kv-ui-elements#905, merged and released as 3.8.32.
Why
Express checkout's credit controls (
ExpressCheckoutTotals.vue→applyKivaCredit/removeKivaCredit) run through kv-shop'scallShopMutation, notsrc/util/basketUtils.js— so CIT-5181 (#7266) does not reach them.Before 3.8.32,
parseShopErrorhad no mapping forcheckout_in_progress/shop.checkoutInProgress, so both hit its catch-all and returned "An unknown error occurred." with the original code rewritten toshop.unknown. That rewrite is why it could not be fixed from ui — there was nothing left to classify on.What
One line in
package.json, plus the lockfile. The lockfile diff touches only@kiva/kv-shop— no other package moved.Verification
npm installNotes
node_moduleswas stale before this (3.8.9 installed against a lockfile pinning 3.8.28). The lockfile itself was fine; only the local install had drifted, andnpm installresolved it. Worth anpm cilocally if you had the same drift.🤖 Generated with Claude Code