Skip to content

CIT-5223: bump @kiva/kv-shop to ^3.8.32 - #7267

Draft
JoeTravisKiva wants to merge 1 commit into
mainfrom
CIT-5223
Draft

JoeTravisKiva wants to merge 1 commit into
mainfrom
CIT-5223

Conversation

@JoeTravisKiva

@JoeTravisKiva JoeTravisKiva commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

CIT-5223 — the ui half. The kv-shop change is kiva/kv-ui-elements#905, merged and released as 3.8.32.

Why

Express checkout's credit controls (ExpressCheckoutTotals.vueapplyKivaCredit / removeKivaCredit) run through kv-shop's callShopMutation, not src/util/basketUtils.js — so CIT-5181 (#7266) does not reach them.

Before 3.8.32, parseShopError had no mapping for checkout_in_progress / shop.checkoutInProgress, so both hit its catch-all and returned "An unknown error occurred." with the original code rewritten to shop.unknown. That rewrite is why it could not be fixed from ui — there was nothing left to classify on.

What

One line in package.json, plus the lockfile. The lockfile diff touches only @kiva/kv-shop — no other package moved.

Verification

  • Confirmed the published 3.8.32 tarball actually contains the fix (both codes and the expected copy) before bumping, rather than assuming the release included it
  • Confirmed the installed build carries it after npm install
  • 341 test files / 5444 tests passing, lint clean (149 warnings, all pre-existing)

Notes

🤖 Generated with Claude Code

3.8.32 adds checkout_in_progress and shop.checkoutInProgress handling to
parseShopError. Without it, a lender applying or removing Kiva credit
during their own in-flight checkout sees "An unknown error occurred."
from express checkout, because those paths run through kv-shop's
callShopMutation rather than src/util/basketUtils.js.

Verified the published build carries the fix before bumping.

CIT-5223

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants