Fix broken swagger-ui doc links (CIT-5067) - #36
Merged
Merged
Conversation
The bare /swagger-ui/ path 404s (Spring Whitelabel Error Page) on both staging and production - the app has no welcome-file mapping for that path. /swagger-ui/index.html works. Fixes all bare links across the English docs, fr/es translations, the docusaurus nav config, and the two sample READMEs that also referenced it. Signed-off-by: Matt Raffel <mattr@kiva.org>
Direct pushes to main bypass required review and were observed to not reliably trigger the merge-deploy GitHub Actions workflow (see CIT-5067) - the change lands on main but never actually goes live. Documents the real publish flow (branch -> PR -> preview check -> merge) in portal/README.md, with a pointer from the root README. Signed-off-by: Matt Raffel <mattr@kiva.org>
|
Visit the preview URL for this PR (updated for commit badeb62): https://fps-sdk-portal--pr36-fix-partner-api-swag-d5biabjp.web.app (expires Wed, 02 Sep 2026 16:42:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7129e37bc287154f12cd4086153fb872043ac1fe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/swagger-ui/path returns a Spring Whitelabel Error Page (404) on both staging and production — the app has no welcome-file mapping for that path;/swagger-ui/index.htmlworks.swagger-uilinks (docs, i18n translations, docusaurus nav config, sample READMEs) to point atswagger-ui/index.html, preserving any#anchorfragments.639fa1e,9ee26b6,3325bd2), which were reverted because they bypassed the required-PR branch protection and the Firebase deploy workflow never ran for them.Test plan
Jira: https://kiva.atlassian.net/browse/CIT-5067