fix(settings): cancel hotkey capture when clicking away - #261
Open
blackforestboi wants to merge 1 commit into
Open
fix(settings): cancel hotkey capture when clicking away#261blackforestboi wants to merge 1 commit into
blackforestboi wants to merge 1 commit into
Conversation
Use one shared capture target so only one settings shortcut field can listen at a time. Cancel capture when the user clicks elsewhere, Settings disappears, or Hex resigns active, and suspend all app hotkey monitors for the whole capture session.
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking away from a shortcut field now ends capture immediately, so the next shortcut—such as Command-Q—keeps its normal macOS behavior instead of being silently reassigned or blocked. A single shared capture session makes settings fields mutually exclusive and pauses every app hotkey while a shortcut is being chosen.
Validated with the unsigned Debug build.