Repository navigation
Remove the committed-image evidence path once open PRs with committed screenshots drain #10069
Description
Deferred from the First Principles Review of #10010 (Subtraction on 598da5f09).
Task: remove the committed-image evidence path once the open PRs that still carry committed screenshots have drained.
PR #10010 moves review evidence to GitHub attachments and gitignores temp-screenshots/ and .github/screenshots/, so no new PR can commit evidence there. It deliberately keeps the code that still reads committed images, because open PRs under the old convention still carry them: at the time of filing, gh pr list --state open --limit 500 --json number,files finds 110 open PRs with files under those two directories.
Once that count reaches zero (or the remaining PRs are closed or re-attached), delete:
- the
shot()loop over committed files inux-review.yml'sCollect blind-read evidencestep (everything after the. "$GITHUB_WORKSPACE/.github/scripts/pr-attachment-evidence.sh"line except thescreens=output and theBlind-read evidence:summary), and theBASE_SHAenv it needs; - the
temp-screenshots//.github/screenshots/alternatives inscreenshot-evidence.yml's evidence regex and its trigger paths; - the
paths:entries for those directories inux-review.yml's trigger; - the "a committed image is still accepted" sentences in the reviewer prompts,
docs/ci/ci-and-reviews.md, and thetest_the_evidence_step_copies_regular_images_under_opaque_names/test_both_lanes_name_the_description_as_the_normal_home_for_evidencepins intest/test_ai_review_workflows.py.
Check first: gh pr list --state open --limit 500 --json number,files --jq '[.[] | select(any(.files[]; .path | test("^(temp-screenshots|\\.github/screenshots)/"))) | .number] | length' must print 0.
Due: 2026-10-31
Activity
github-actions commentedon Sep 11, 2026
Automated triage summary — generated from the issue text alone, before any maintainer has read it. Treat every line as a starting point, not a verdict.
Follow-up cleanup task deferred from PR #10010's review: now that review evidence moves to GitHub attachments and the old screenshot directories are gitignored, the code paths that still read committed images should be deleted once the ~110 open PRs carrying such files drain. The report lists the exact workflow steps, prompts, docs and test pins to remove, plus a gh query gate that must return 0 first.
Possibly already reported
If one of these is the same problem, say so and we will close this as a duplicate.
Posted by
issue-summary.yml. The model had no access to the repository — it read only this issue and the titles of recent ones.KiroCrewCaptain commentedon Oct 8, 2026
Thanks for the report. This issue has been triaged by Crew Captain and will be assigned to a maintainer, who will follow up here.
bolichen97 commentedon Oct 15, 2026
[operator: bolichen97]
Drain check for this cleanup, run 2026-10-14 ~21:20 PDT against
mainat3d095142283f04c8c658257aae7acd8734cfdc8a.The committed-image path is still on
main(shot()loop andBASE_SHAinux-review.yml'sCollect blind-read evidencestep, thetemp-screenshots/alternative inscreenshot-evidence.yml). The gate is not met: 85 of 716 open PRs still change files undertemp-screenshots/or.github/screenshots/, so the path stays for now. No PR opened.Open PRs that still carry committed images:
#1515 #3987 #5274 #6602 #7163 #7336 #7821 #8360 #8463 #8985 #9118 #9314 #9453 #9485 #9750 #10107 #10175 #10383 #10708 #10931 #10965 #10966 #11030 #11100 #11397 #12829 #12932 #13337 #13881 #14233 #14316 #14574 #14739 #14767 #14809 #15041 #15111 #15172 #15427 #15543 #15592 #15957 #16004 #16349 #16481 #16831 #16906 #16962 #17080 #17094 #17525 #17542 #17755 #17784 #18114 #18180 #18207 #18487 #18517 #18808 #18844 #19040 #19226 #19439 #19557 #19721 #19820 #19824 #19859 #19916 #19948 #19963 #20004 #20033 #20040 #20044 #20045 #20109 #20175 #20281 #20372 #20441 #20493 #20592 #20603
Method: GraphQL page over all open PRs, first 100 files each, path matched against
^(temp-screenshots|\.github/screenshots)/. The one-shotgh pr list --limit 500 --json number,filesin the issue body now times out (HTTP 504) at this PR count. 14 PRs have more than 100 files, so the count is a floor, not a ceiling.Recheck before the 2026-10-31 due date; the removal list in the issue body is still accurate.
bolichen97 commentedon Oct 18, 2026
[operator: bolichen97]
Drain recheck, 2026-10-17 ~19:45 PDT, against
mainat6ed866fdfa76f6ef77da4ba92be96e1e3227c099.The gate is still not met: 95 of 752 open PRs still change files under
temp-screenshots/or.github/screenshots/(was 85 of 716 on 10-14). The committed-image path stays. No PR opened.Open PRs that still carry committed images:
#1515 #3987 #5274 #6602 #7163 #7336 #7821 #8360 #8463 #8985 #9118 #9314 #9453 #9750 #10107 #10175 #10383 #10708 #10838 #10931 #10965 #10966 #11030 #11100 #11397 #12829 #12932 #13337 #14316 #14574 #14739 #14767 #14809 #15041 #15111 #15172 #15427 #15543 #15592 #15957 #16349 #16481 #16831 #16906 #16962 #17094 #17525 #17542 #17755 #17784 #18114 #18180 #18207 #18487 #18517 #18808 #18831 #18844 #19040 #19226 #19439 #19557 #19820 #19824 #19859 #19916 #19948 #19963 #20004 #20033 #20040 #20044 #20045 #20109 #20281 #20493 #20603 #20651 #20672 #20960 #20981 #20994 #21007 #21031 #21092 #21098 #21175 #21177 #21193 #21197 #21222 #21266 #21404 #21467 #21496
Not fully scanned (more than 100 changed files, so the count is a floor): #7157 #9201 #14089 #15720 #17554 #19245 #19274 #19833 #19883 #20965 #21429 #21437 #21633
Method: GraphQL page over all open PRs, first 100 files each, path matched against
^(temp-screenshots|\.github/screenshots)/.The count is rising, not draining: 20 of these were not in the 10-14 list, so PRs still commit images despite the gitignore. Waiting alone will likely not reach zero before the 2026-10-31 due date; the remaining PRs need their images moved to attachments, or to be closed.
bolichen97 commentedon Oct 19, 2026
[operator: bolichen97]
Closing as superseded by #13201.
Since #13201, committing images under
temp-screenshots/is the supported evidence path for fork PRs, because GitHub refusesgh --attachuploads from forks. Main wires it in.github/scripts/pr-committed-evidence.sh,screenshot-evidence.ymland the fork-PR section ofdocs/ci/ci-and-reviews.md. Removing the committed-image path, as this issue asked, would break that path.Recheck 2026-10-18: 99 open PRs carry committed images, 83 of them from forks.