Repository navigation
Sync: stale reports spend no budget and log once a minute - #109
Merged
Merged
Conversation
Follow-ups to #106 from review: - Reports too far from now for the wire are left out before the sync byte budget is charged, so current reports are not deferred for bytes never sent. - They are logged at most once a minute, with a count and a few tracks, so replaying old data does not flood the log. - The engine tests' t0 is computed once per run, so a run across midnight UTC keeps one time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #106, from the code review of the #104 work:
within_budget, so they no longer use up the sync byte allowance and push current reports to later flushes.t0()is computed once per run (OnceLock), so a run that crosses midnight UTC keeps one time.Gate (dev server):
cargo fmt --checkandcargo clippy --workspace --all-targets -D warningspass. ot-server 227/227, ot-sync 27/27.🤖 Generated with Claude Code