Skip to content

Upgrades Vitest to v5 and fixes async assertions - #118

Merged
Koosha-Owji merged 1 commit into
mainfrom
fix/vitest-5-migration
Oct 5, 2026
Merged

Koosha-Owji merged 1 commit into
mainfrom
fix/vitest-5-migration

Conversation

@dtoxvanilla1991

Copy link
Copy Markdown
Contributor

Upgrades the Vitest testing framework and its coverage tool to version 5 to stay up-to-date with the latest testing features, performance improvements, and dependencies.
Kills #110

Key Changes

  • Awaits Async Assertions: Fixes test assertions by properly awaiting rejected promises. Vitest 5 requires explicit awaiting of asynchronous expectations (like .rejects), which otherwise fail silently or cause test instability.
  • Updates Documentation: Adds a "Development and testing" section to the README outlining the Node.js version requirement (v22.12+) and highlighting the Vitest 5 assertion rules for contributors.

@dtoxvanilla1991 dtoxvanilla1991 self-assigned this Oct 4, 2026
@dtoxvanilla1991
dtoxvanilla1991 requested review from a team as code owners October 4, 2026 14:14
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 21b645ec-a0ae-4315-af39-8cfc49e53ebe
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Successful CI validation of the major test-toolchain upgrade was not verified.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Upgrades the JWT validator’s test toolchain to Vitest 5 and updates tests and contributor guidance.

Changes:

  • Upgrades Vitest and V8 coverage, locking both to 5.0.3.
  • Awaits rejected-promise assertions in JWKS failure tests.
  • Documents development requirements and testing commands.
File Description
readme.md Adds development and testing guidance.
pnpm-lock.yaml Locks Vitest 5 and updated dependencies.
package.json Updates Vitest and coverage version ranges.
lib/​tests/​badPathTest.test.ts Awaits asynchronous rejection assertions.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread readme.md
Comment on lines +44 to +46
The development toolchain requires Node.js 22.12 or newer and the pnpm version
pinned in `package.json`. These are development requirements, not consumer runtime
requirements.
@Koosha-Owji
Koosha-Owji merged commit 34667e8 into main Oct 5, 2026
6 checks passed
@Koosha-Owji
Koosha-Owji deleted the fix/vitest-5-migration branch October 5, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants