Repository navigation
Add callback transactions and a public ORM - #2
Merged
Merged
Conversation
transaction() groups add, set, and del so they write the file once. A throw restores the pages and leaves the file untouched. Collection models are imported from @kin-lang/db/orm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transaction(callback)groupsadd,set,del, and the other mutations into one file write. A throw restores the pages from the start of that callback and leaves the file untouched. A nested call is a savepoint, and the callback has to finish synchronously.@kin-lang/db/orm.kora,shira,hitamo,hindura, andsibarun on the bound database or transaction, so they join an opentransaction().Testing
npm testpassed locally: 65 tests across engine, ORM, index, and perf.