Repository navigation
fix(for-you): the drag reveal starts: a CSS-hidden modal layer is not an open overlay - #668
Merged
Merged
Conversation
… an open overlay On the operator's phone the drag never began. crow-talk.js renders <div id=crow-talk-overlay role=dialog aria-modal=true> into every layout, hidden by CSS until .active, and the guard '[aria-modal=true]:not([hidden])' matched it on every page. Open overlays are now an open <dialog>, or an aria-modal layer that is actually displayed (computed display and visibility), not aria-hidden. Claude-Session: https://claude.ai/code/session_01N9fXzvNy8rCEArj1y5p6fp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On the operator's phone, the For You drag reveal (#667) never started.
crow-talk.jsrenders<div id="crow-talk-overlay" role="dialog" aria-modal="true">into every layout, hidden by CSS until it gets.active. The drag's "a drawer, sheet or dialog is open" guard used[aria-modal="true"]:not([hidden]), which matched that always-present layer on every page, so the drag was refused everywhere.What changes
shell/client.jsoverlayOpen(): an overlay now counts as open only when it's one of these:<dialog>;aria-modal="true"layer that isn't[hidden], isn'taria-hidden="true", and is actually displayed (computeddisplayisn'tnoneandvisibilityisn'thidden).Tests
tests/for-you-page.test.js: a new case renders Crow Talk's real overlay shape..active: no drag.getComputedStylenow models the overlay's CSS.https://claude.ai/code/session_01N9fXzvNy8rCEArj1y5p6fp