Support Redis TLS server name#105
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: Changes are to Redis client configuration (src/lib/redis.ts) and documentation, not to API endpoints (packages/api/cmd/api/) or Temporal workflows (packages/api/lib/temporal) as specified in the filter. To monitor this PR anyway, reply with |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 28fe644. Configure here.
| tls: true, | ||
| servername: redisTlsServerName, | ||
| reconnectStrategy, | ||
| } |
There was a problem hiding this comment.
Redundant socket.host may drop non-standard URL port
Medium Severity
Setting socket.host without socket.port when url is also provided risks losing the port from the URL. If socket.host takes effect, socket.port defaults to 6379, silently ignoring any non-standard port in the rediss:// URL. The official node-redis pattern for adding servername alongside a url only sets tls and servername in the socket config—not host. Omitting socket.host (and socket.tls, which rediss:// already implies) avoids this risk and removes the need for parsedRedisUrl and the non-null assertion entirely.
Reviewed by Cursor Bugbot for commit 28fe644. Configure here.


Summary
Testing
Note
Low Risk
Small, opt-in connection configuration for managed Redis TLS; no changes to auth or data key logic.
Overview
Adds optional TLS SNI support for Redis when connecting over
rediss://.The MCP Redis client now reads
REDIS_TLS_SERVER_NAMEand, when set, configures the socket withtls: trueandservername(using the URL hostname forhost). Startup fails fast if that variable is set butREDIS_URLis notrediss://. Reconnect backoff is unchanged; it is just shared via a small refactor..env.exampledocuments the new optional variable.Reviewed by Cursor Bugbot for commit 28fe644. Bugbot is set up for automated code reviews on this repo. Configure here.