Repository navigation
fix: publish releases only after all assets are ready - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases became public before the desktop installers finished uploading. Keep the release draft through native and desktop builds, then publish only after all 26 expected assets are uploaded and nonempty. Run the Homebrew update after publication.
Find drafts through the authenticated, paginated releases list. Check for an already public tag in the release job and each desktop upload path so rerunning a job cannot reuse an old preflight result and overwrite public assets. Fail closed on lookup errors and missing build artifacts.
Validation:
bun run validatepassed locally with 196 tests, including 37 release gate tests; typechecks and formatting passed. Six existing calendar lint warnings remain. Workflow YAML, publication dependencies, and upload guards were checked. A live read-only check rejected the existing public v1.0.0 release. Full signed release packaging was not run.