Repository navigation
fix(windows): use system tar and Windows PowerShell modules in update checks - #73
Merged
Merged
Conversation
Merged
4 tasks done
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
%SystemRoot%\System32\tar.exeby absolute path instead of lookingtarup on PATH.powershell.exewithout the inheritedPSModulePath.Why
The Windows CI guest now runs steps in PowerShell 7 (
pwsh); onmainin run 38669251591 (2026-10-15) every step used Windows PowerShell. Since then two things fail on every PR, including ones that do not touch these files:update.test.tsfails withtar: Cannot connect to C: resolve failed, because a GNU tar is now found first on PATH. The updater has the same exposure on users' machines. Windows release archives are zip files that only the system bsdtar extracts, and an updater should not run whatevertarcomes first on PATH.install-windows.test.mjsfails withGet-FileHash is not recognized. PowerShell 7 exports its own module path, and a child Windows PowerShell 5.1 then cannot load its built-in cmdlets.The installer itself is unchanged.
Checklist
pnpm checkpasses locallyProof: this PR's Windows job, where the first commit already turned
pnpm checkgreen.