Skip to content

fix(windows): use system tar and Windows PowerShell modules in update checks - #73

Merged
kerdofficial merged 2 commits into
mainfrom
fix/windows-system-tar
Oct 23, 2026
Merged

kerdofficial merged 2 commits into
mainfrom
fix/windows-system-tar

Conversation

@kerdofficial

@kerdofficial kerdofficial commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • On Windows, the updater and its test call %SystemRoot%\System32\tar.exe by absolute path instead of looking tar up on PATH.
  • The PowerShell installer tests start powershell.exe without the inherited PSModulePath.

Why

The Windows CI guest now runs steps in PowerShell 7 (pwsh); on main in run 38669251591 (2026-10-15) every step used Windows PowerShell. Since then two things fail on every PR, including ones that do not touch these files:

  • update.test.ts fails with tar: Cannot connect to C: resolve failed, because a GNU tar is now found first on PATH. The updater has the same exposure on users' machines. Windows release archives are zip files that only the system bsdtar extracts, and an updater should not run whatever tar comes first on PATH.
  • install-windows.test.mjs fails with Get-FileHash is not recognized. PowerShell 7 exports its own module path, and a child Windows PowerShell 5.1 then cannot load its built-in cmdlets.

The installer itself is unchanged.

Checklist

  • The PR title follows conventional commits
  • The PR does one thing
  • pnpm check passes locally
  • Every affected surface is covered (updater, installer tests)

Proof: this PR's Windows job, where the first commit already turned pnpm check green.

@kerdofficial kerdofficial changed the title fix(update): use the system tar on Windows fix(windows): use system tar and Windows PowerShell modules in update checks Oct 22, 2026
@kerdofficial kerdofficial mentioned this pull request Oct 22, 2026
4 tasks done
@kerdofficial
kerdofficial merged commit d460309 into main Oct 23, 2026
5 of 6 checks passed
@kerdofficial
kerdofficial deleted the fix/windows-system-tar branch October 23, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant