Skip to content

fix(Deezer): Deduplicate release and track contributors #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaban-mb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Deezer): Deduplicate release and track contributors #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions providers/Deezer/mod.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { ReleaseOptions } from '@/harmonizer/types.ts';
import { describeProvider, makeProviderOptions } from '@/providers/test_spec.ts';
import { stubProviderLookups } from '@/providers/test_stubs.ts';
import { assert } from 'std/assert/assert.ts';
import { assertEquals } from 'std/assert/assert_equals.ts';
import { afterAll, describe } from '@std/testing/bdd';
import { assertSnapshot } from '@std/testing/snapshot';

Expand Down Expand Up @@ -66,6 +67,26 @@ describe('Deezer provider', () => {
assert(allTracks.every((track) => track.artists?.length === 1), 'Tracks should not have multiple artists');
assert(allTracks.every((track) => !track.isrc), 'Tracks should not have an ISRC');
},
}, {
description: 'release with duplicate artist roles in track contributors',
release: '792408001',
options: releaseOptions,
assert: (release) => {
const allTracks = release.media.flatMap((medium) => medium.tracklist);
// Track 2 (THEORY - SLOWED) has MoonDeity as both 'Main' and 'Featured' contributor in Deezer API
assertEquals(allTracks[1].artists?.map((a) => a.name), ['MoonDeity', 'Archez']);
},
}, {
description: 'release with multiple tracks having duplicate artist roles in contributors',
release: '1034546172',
options: releaseOptions,
assert: (release) => {
const allTracks = release.media.flatMap((medium) => medium.tracklist);
// Tracks 2-5 have Shibuya Nasu and Pakto as both 'Main' and 'Featured'
for (const track of allTracks) {
assertEquals(track.artists?.map((a) => a.name), ['Shibuya Nasu', 'Pakto']);
}
},
}],
});

Expand Down
5 changes: 3 additions & 2 deletions providers/Deezer/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { parseHyphenatedDate, PartialDate } from '@/utils/date.ts';
import { splitLabels } from '@/utils/label.ts';
import { ProviderError, ResponseError } from '@/utils/errors.ts';
import { formatGtin, isEqualGTIN } from '@/utils/gtin.ts';
import { distinctBy } from '@std/collections/distinct-by';

import type { ApiError, MinimalArtist, Release, ReleaseTrack, Result, Track, TracklistItem } from './api_types.ts';
import type {
Expand Down Expand Up @@ -204,7 +205,7 @@ export class DeezerReleaseLookup extends ReleaseApiLookup<DeezerProvider, Releas

return {
title: rawRelease.title,
artists: rawRelease.contributors.map(this.convertRawArtist.bind(this)),
artists: distinctBy(rawRelease.contributors, (c) => c.id).map(this.convertRawArtist.bind(this)),
gtin: rawRelease.upc,
externalLinks: [{
url: rawRelease.link,
Expand Down Expand Up @@ -274,7 +275,7 @@ export class DeezerReleaseLookup extends ReleaseApiLookup<DeezerProvider, Releas

if ('contributors' in track) {
// all available details about this track have been fetched
result.artists = track.contributors.map(this.convertRawArtist.bind(this));
result.artists = distinctBy(track.contributors, (c) => c.id).map(this.convertRawArtist.bind(this));
result.availableIn = track.available_countries;
} else {
result.artists = [this.convertRawArtist(track.artist)];
Expand Down
1 change: 1 addition & 0 deletions testdata/https!/com.deezer.api/album/1034546172
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"id":1034546172,"title":"ANGEL BREAK","upc":"881453357152","link":"https:\/\/www.deezer.com\/album\/1034546172","share":"https:\/\/www.deezer.com\/album\/1034546172?utm_source=deezer&utm_content=album-1034546172&utm_term=0_1789327119&utm_medium=web","cover":"https:\/\/api.deezer.com\/album\/1034546172\/image","cover_small":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/56x56-000000-80-0-0.jpg","cover_medium":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/250x250-000000-80-0-0.jpg","cover_big":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/500x500-000000-80-0-0.jpg","cover_xl":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/1000x1000-000000-80-0-0.jpg","md5_image":"7806c4bea738d67a7cc0ea312798c560","genre_id":106,"genres":{"data":[{"id":106,"name":"Electro","picture":"https:\/\/api.deezer.com\/genre\/106\/image","type":"genre"},{"id":113,"name":"Dance","picture":"https:\/\/api.deezer.com\/genre\/113\/image","type":"genre"}]},"label":"Ictasis Music Group","nb_tracks":5,"duration":810,"fans":0,"release_date":"2026-08-14","record_type":"ep","available":true,"tracklist":"https:\/\/api.deezer.com\/album\/1034546172\/tracks","explicit_lyrics":false,"explicit_content_lyrics":0,"explicit_content_cover":2,"contributors":[{"id":126670532,"name":"Shibuya Nasu","link":"https:\/\/www.deezer.com\/artist\/126670532","share":"https:\/\/www.deezer.com\/artist\/126670532?utm_source=deezer&utm_content=artist-126670532&utm_term=0_1789327119&utm_medium=web","picture":"https:\/\/api.deezer.com\/artist\/126670532\/image","picture_small":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/56x56-000000-80-0-0.jpg","picture_medium":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/250x250-000000-80-0-0.jpg","picture_big":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/500x500-000000-80-0-0.jpg","picture_xl":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/1000x1000-000000-80-0-0.jpg","radio":true,"tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist","role":"Main"},{"id":111523772,"name":"Pakto","link":"https:\/\/www.deezer.com\/artist\/111523772","share":"https:\/\/www.deezer.com\/artist\/111523772?utm_source=deezer&utm_content=artist-111523772&utm_term=0_1789327119&utm_medium=web","picture":"https:\/\/api.deezer.com\/artist\/111523772\/image","picture_small":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/8d1184a30f8612d4fb9ace03359d8ffe\/56x56-000000-80-0-0.jpg","picture_medium":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/8d1184a30f8612d4fb9ace03359d8ffe\/250x250-000000-80-0-0.jpg","picture_big":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/8d1184a30f8612d4fb9ace03359d8ffe\/500x500-000000-80-0-0.jpg","picture_xl":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/8d1184a30f8612d4fb9ace03359d8ffe\/1000x1000-000000-80-0-0.jpg","radio":true,"tracklist":"https:\/\/api.deezer.com\/artist\/111523772\/top?limit=50","type":"artist","role":"Main"}],"artist":{"id":126670532,"name":"Shibuya Nasu","picture":"https:\/\/api.deezer.com\/artist\/126670532\/image","picture_small":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/56x56-000000-80-0-0.jpg","picture_medium":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/250x250-000000-80-0-0.jpg","picture_big":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/500x500-000000-80-0-0.jpg","picture_xl":"https:\/\/cdn-images.dzcdn.net\/images\/artist\/97ad10c182193d13540835f27f42149c\/1000x1000-000000-80-0-0.jpg","tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist"},"type":"album","tracks":{"data":[{"id":4168096982,"readable":true,"title":"ANGEL BREAK","title_short":"ANGEL BREAK","title_version":"","link":"https:\/\/www.deezer.com\/track\/4168096982","duration":141,"rank":100000,"explicit_lyrics":false,"explicit_content_lyrics":0,"explicit_content_cover":2,"preview":"https:\/\/cdnt-preview.dzcdn.net\/api\/1\/1\/4\/e\/7\/0\/4e73488ac14cfa2855bb658276e442cb.mp3?hdnea=exp=1789328019~acl=\/api\/1\/1\/4\/e\/7\/0\/4e73488ac14cfa2855bb658276e442cb.mp3*~data=user_id=0,application_id=42~hmac=e35ac110544fb7348a47037c297b28351eddfac8c88ee89b16d0bb3962eba862","md5_image":"7806c4bea738d67a7cc0ea312798c560","artist":{"id":126670532,"name":"Shibuya Nasu","tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist"},"album":{"id":1034546172,"title":"ANGEL BREAK","cover":"https:\/\/api.deezer.com\/album\/1034546172\/image","cover_small":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/56x56-000000-80-0-0.jpg","cover_medium":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/250x250-000000-80-0-0.jpg","cover_big":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/500x500-000000-80-0-0.jpg","cover_xl":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/1000x1000-000000-80-0-0.jpg","md5_image":"7806c4bea738d67a7cc0ea312798c560","tracklist":"https:\/\/api.deezer.com\/album\/1034546172\/tracks","type":"album"},"type":"track"},{"id":4168096992,"readable":true,"title":"ANGEL BREAK (slowed)","title_short":"ANGEL BREAK","title_version":"(slowed)","link":"https:\/\/www.deezer.com\/track\/4168096992","duration":157,"rank":100000,"explicit_lyrics":false,"explicit_content_lyrics":0,"explicit_content_cover":2,"preview":"https:\/\/cdnt-preview.dzcdn.net\/api\/1\/1\/4\/3\/2\/0\/4327632149ea0afa80d15a13a4af3497.mp3?hdnea=exp=1789328019~acl=\/api\/1\/1\/4\/3\/2\/0\/4327632149ea0afa80d15a13a4af3497.mp3*~data=user_id=0,application_id=42~hmac=ca56b4ca24b290882c77c7d00c24979ad5844d9deb71e76b7ead4e713c09bcc3","md5_image":"7806c4bea738d67a7cc0ea312798c560","artist":{"id":126670532,"name":"Shibuya Nasu","tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist"},"album":{"id":1034546172,"title":"ANGEL BREAK","cover":"https:\/\/api.deezer.com\/album\/1034546172\/image","cover_small":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/56x56-000000-80-0-0.jpg","cover_medium":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/250x250-000000-80-0-0.jpg","cover_big":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/500x500-000000-80-0-0.jpg","cover_xl":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/1000x1000-000000-80-0-0.jpg","md5_image":"7806c4bea738d67a7cc0ea312798c560","tracklist":"https:\/\/api.deezer.com\/album\/1034546172\/tracks","type":"album"},"type":"track"},{"id":4168097002,"readable":true,"title":"ANGEL BREAK (super slowed)","title_short":"ANGEL BREAK","title_version":"(super slowed)","link":"https:\/\/www.deezer.com\/track\/4168097002","duration":176,"rank":100000,"explicit_lyrics":false,"explicit_content_lyrics":0,"explicit_content_cover":2,"preview":"https:\/\/cdnt-preview.dzcdn.net\/api\/1\/1\/6\/b\/1\/0\/6b1f7b337fd32f0ce364cba1b19e2b70.mp3?hdnea=exp=1789328019~acl=\/api\/1\/1\/6\/b\/1\/0\/6b1f7b337fd32f0ce364cba1b19e2b70.mp3*~data=user_id=0,application_id=42~hmac=9cb9409a897aa24895da119e542a9087113bc51fa94d7656eeb57c039a597228","md5_image":"7806c4bea738d67a7cc0ea312798c560","artist":{"id":126670532,"name":"Shibuya Nasu","tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist"},"album":{"id":1034546172,"title":"ANGEL BREAK","cover":"https:\/\/api.deezer.com\/album\/1034546172\/image","cover_small":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/56x56-000000-80-0-0.jpg","cover_medium":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/250x250-000000-80-0-0.jpg","cover_big":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/500x500-000000-80-0-0.jpg","cover_xl":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/1000x1000-000000-80-0-0.jpg","md5_image":"7806c4bea738d67a7cc0ea312798c560","tracklist":"https:\/\/api.deezer.com\/album\/1034546172\/tracks","type":"album"},"type":"track"},{"id":4168097012,"readable":true,"title":"ANGEL BREAK (ultra slowed)","title_short":"ANGEL BREAK","title_version":"(ultra slowed)","link":"https:\/\/www.deezer.com\/track\/4168097012","duration":202,"rank":100000,"explicit_lyrics":false,"explicit_content_lyrics":0,"explicit_content_cover":2,"preview":"https:\/\/cdnt-preview.dzcdn.net\/api\/1\/1\/9\/7\/f\/0\/97fa90671539baec8342402279509576.mp3?hdnea=exp=1789328019~acl=\/api\/1\/1\/9\/7\/f\/0\/97fa90671539baec8342402279509576.mp3*~data=user_id=0,application_id=42~hmac=55d9046c1695986659d333eafbb2b3129ba60b62ed0ed9e19ce221e1594090b9","md5_image":"7806c4bea738d67a7cc0ea312798c560","artist":{"id":126670532,"name":"Shibuya Nasu","tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist"},"album":{"id":1034546172,"title":"ANGEL BREAK","cover":"https:\/\/api.deezer.com\/album\/1034546172\/image","cover_small":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/56x56-000000-80-0-0.jpg","cover_medium":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/250x250-000000-80-0-0.jpg","cover_big":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/500x500-000000-80-0-0.jpg","cover_xl":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/1000x1000-000000-80-0-0.jpg","md5_image":"7806c4bea738d67a7cc0ea312798c560","tracklist":"https:\/\/api.deezer.com\/album\/1034546172\/tracks","type":"album"},"type":"track"},{"id":4168097022,"readable":true,"title":"ANGEL BREAK (sped up)","title_short":"ANGEL BREAK","title_version":"(sped up)","link":"https:\/\/www.deezer.com\/track\/4168097022","duration":134,"rank":31884,"explicit_lyrics":false,"explicit_content_lyrics":0,"explicit_content_cover":2,"preview":"https:\/\/cdnt-preview.dzcdn.net\/api\/1\/1\/b\/8\/7\/0\/b8701c84a536db78e9246f06403c01bf.mp3?hdnea=exp=1789328019~acl=\/api\/1\/1\/b\/8\/7\/0\/b8701c84a536db78e9246f06403c01bf.mp3*~data=user_id=0,application_id=42~hmac=a90106e81e4cab0b66bda2f20fda898f62b04c6a87a1b10081378c1dd6754c21","md5_image":"7806c4bea738d67a7cc0ea312798c560","artist":{"id":126670532,"name":"Shibuya Nasu","tracklist":"https:\/\/api.deezer.com\/artist\/126670532\/top?limit=50","type":"artist"},"album":{"id":1034546172,"title":"ANGEL BREAK","cover":"https:\/\/api.deezer.com\/album\/1034546172\/image","cover_small":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/56x56-000000-80-0-0.jpg","cover_medium":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/250x250-000000-80-0-0.jpg","cover_big":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/500x500-000000-80-0-0.jpg","cover_xl":"https:\/\/cdn-images.dzcdn.net\/images\/cover\/7806c4bea738d67a7cc0ea312798c560\/1000x1000-000000-80-0-0.jpg","md5_image":"7806c4bea738d67a7cc0ea312798c560","tracklist":"https:\/\/api.deezer.com\/album\/1034546172\/tracks","type":"album"},"type":"track"}]}}
Loading