Skip to content

No image for certain players #6

Description

@molano999

Hello,

Let me start by saying that I feel bad of having to bother you again. I really love this program and appreciate hugely what you do for baseball/softball, and for us!

I noticed that for "some" players at bat, the player image and team image is not loaded. I double checked on our local wbsc site (baseballsoftball.be) and on the overall stats site (wbsc.org) and the pictures are there. So I am buffled to why some images are not retrieved.

I have this e.g. in game java -jar "C:\OBS_DataDirectory\baseball-streaming-v1.8.1.jar" -m replay -t "C:\OBS_DataDirectory\resources" -s 2024-softball-ladies-d1 -g 133609 -S https://www.baseballsoftball.be/ where (amongst others) the picture of Roxanne Struyf (https://www.wbsc.org/en/player/struyf-roxanne-646956/history) is not loaded.
Other players for that game that are not loaded are "Floortje De Ridder" and "Marijke Neerinckx"

I dived in your code, and I think the problem is related to https://github.com/keero/baseball-streaming/blob/6a0eff16c573e7d9d84a8e907a7b3d95363cdf65/src/main/java/org/sundbybergheat/baseballstreaming/services/FilesService.java#L389 , but I could not put my finger on what exactly is wrong... (because I can't fully understand JAVA 😄)

So if you would have some extra spare time to find out what could be wrong, I would appreciate it a lot! But it's not thàt important. ;)

Thank you already!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions