Skip to content

ci: retire the CircleCI job, GitHub Actions already supersedes it #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BitHighlander wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: retire the CircleCI job, GitHub Actions already supersedes it #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 0 additions & 71 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

33 changes: 28 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,37 @@
# KeepKey python-keepkey CI
#
# Pulls the published emulator image (kktech/kkemu) from DockerHub
# and runs the full python integration test suite against it.
#
# Stage 1: GATE (seconds)
# └─ lint basic Python syntax check
#
# Stage 2: TEST (gated by Stage 1)
# └─ integration full pytest suite against emulator

# └─ integration full pytest suite against the kktech/kkemu service image
#
# NOTE on what this job tests: it runs against a PUBLISHED emulator image, so
# it tests the tests against whatever firmware that image was built from, not
# against current firmware. Suites that gate on requires_firmware() therefore
# SKIP rather than fail when the image is older than the feature -- the run
# stays green while covering less than it appears to. Building the emulator
# from current firmware in this job is the fix, and is what removes the
# caveat; it is not done here.
#
# This is the ONLY CI for this repo. A CircleCI job (emulator-build-test) ran
# alongside it and is retired here -- see .circleci/config.yml in history.
# It is not worth keeping:
#
# * It cloned firmware `master` unconditionally, so a branch carrying a newer
# test harness was always run against older firmware, and failed for a
# reason the pull request did not cause. It has been red since build #673
# while these workflows stayed green on the same commits.
# * It set no timeouts. A hung test produced no output until CircleCI killed
# the job at ten minutes, which reports a timeout rather than a failing
# test and discards every result after the hang.
# * Its own result collection was broken independently: the final step read
# test-reports/python-keepkey/status, which no longer exists, so the job
# could not report a verdict even when the suite completed.
# * It also ran the firmware's C++ firmware-unit suite, which covers firmware
# code that no change in THIS repo can affect, and which the firmware repo
# already runs in its own CI.
#
name: CI

on:
Expand Down
Loading