feat(clearsign): authenticate Portals EVM swaps - #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes the reported ETH-to-Base Portals route without enabling Advanced Mode. Vault asks the production ClearSign service by privacy-preserving shape only, attaches the certified v4 envelope, and lets 7.16 decode the real transaction on-device.
User review
The device shows:
Fail-closed behavior
Unknown/malformed/service-declined routes retain the existing blind-signing gate. Vault validates service bindings and the certified key id before hdwallet; firmware validates both signatures, exact chain/router/selector, ABI structure, outer order fields, and
msg.value == inputAmount. The cloud signer never receives calldata or argument values and cannot supply displayed values.Evidence
a9531b9d.0xbf5A...5E62, selector0xa2e42c65, 1,476 bytes -> VERIFIED v4 envelope.