Repository navigation
PAT-2167 Apps Proxy preview links (1/3): config and JWKS key set - #2662
Merged
Merged
Conversation
This was referenced Sep 29, 2026
pepamartinec
added this pull request to stack #2664
September 29, 2026 14:06
…onse has no keys field
… values it is used for
…n file with its test
…e request is cancelled
…d merge concurrent refetches
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 3/5) · profile psgo
New auth/crypto code (JWKS ES256 verification + HMAC session key) in load-bearing apps-proxy needs a human, despite not being wired in yet.
Concerns:
internal/pkg/service/appsproxy/proxy/apphandler/authproxy/preview/jwks.go: New JWKS/ES256 signature-verification crypto in apps-proxy auth path; needs human review of verification rules.internal/pkg/service/appsproxy/config/config.go: Adds HMAC sessionSigningKey (sensitive) and preview auth config; credential handling requires human sign-off.internal/pkg/service/appsproxy/proxy/apphandler/authproxy/preview/jwks_test.go: Concurrency test uses time.Sleep(100ms); flake risk (coaching, non-blocking).
Suggested reviewers: @keboola/platform-services
Matovidlo
requested changes
Sep 30, 2026
Matovidlo
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
https://linear.app/keboola/issue/PAT-2167
Part 1 of 3 of preview links for dev-mode apps: sandboxes-service mints a 60 s ES256 link, apps-proxy redeems it for a session cookie. This part adds the
preview.*config and the JWKS key set. Nothing is wired into request handling yet.Key entries are parsed by go-jose (
jose.JSONWebKey: exact coordinate length, point on the curve). Fetching and caching are ours:go-oidc'sRemoteKeySetrefetches on every unknownkid(anyone can make us hammer sandboxes-service), never expires old keys and has no body cap;keyfunc/jwksethas refresh and a rate limit, but would still need our own code for failing closed after 1 h without a good fetch, not blocking boot on the first fetch, the 64 KiB cap, no redirects, skipping one bad entry, and fake-clock tests. A failed fetch (including a 200 without akeysfield) keeps the last good set, only an explicit{"keys":[]}clears it, and requests that arrive during an unknown-kidrefetch wait for it.Plans for customer communication
None.
Impact analysis
No impact. The new code is not called yet.
Change type
New feature
Justification
Let agents and the kbc-ui iframe open dev-mode apps through a short-lived signed link instead of the kai-preview handshake.
Deployment
Merge & automatic deploy.
Rollback plan
Revert of this PR.
Post release support plan
None.