[2mind]

Summary

The initializingworkspaces provider discarded the event recorder
(_ recorder.EventRecorderGetter) and NewScopedInitializingCluster never set
the eventRecorderGetter field, leaving it nil. Any subsequent
GetEventRecorderFor/GetEventRecorder call dereferences the nil getter and
panics, crashing the kcp init-agent reconciler on every workspace reconcile.
The workspace then stays Initializing indefinitely (the InitTemplate is never
applied) — a functional blocker, not just noisy logs.

Pass the recorder through initializingworkspaces and set the field in
NewScopedInitializingCluster, mirroring NewScopedCluster.

What Type of PR Is This?

/kind bug
/kind api-change

Related Issue(s)

Fixes kcp-dev/init-agent#25

Release Notes

Fix a nil event recorder panic in the initializingworkspaces provider

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign scheeles for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kcp-ci-bot]

Hi @2mind. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[embik]

Hi @2mind, thank you for the contribution! Can you please restore the PR description format (see here) and fill it in, so that your PR gets a release note? Thanks.

[2mind]

/kind bug
/kind api-change

[2mind]

@embik done — the description follows the template now and includes a release note.

[2mind]

Friendly ping — the PR description was fixed per @embik's request on Sep 24, still awaiting review. Context: we run a patched init-agent build downstream (this fix + kcp-dev/init-agent#34) and would like to return to the upstream image once both land.