Skip to content

bump otel dependencies (CVE-2026-24051) - #3883

Closed
xrstf wants to merge 2 commits into
kcp-dev:mainfrom
xrstf:bump-otel-sdk
Closed

xrstf wants to merge 2 commits into
kcp-dev:mainfrom
xrstf:bump-otel-sdk

Conversation

@xrstf

@xrstf xrstf commented Mar 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This is to fix the security advisory https://github.com/kcp-dev/kcp/security/dependabot/121.

There are also two more advisories for the client-go and SDK modules in this repo, but using the same logic as in kcp-dev/api-syncagent#137 (comment)

I disagree with this change. The SDK should have the lowest compatible version listed, to increase its usefulness to consumers. Forcing everyone who imports our SDK onto a newer, and in this case even specific, Go version is IMHO the wrong approach. Just like the dependencies in the SDK should be the oldest compatible versions the SDK can work with.

... I did not bump dependencies in those two other modules. It's not up to us to dictate how consumers of our SDK/client-go handle their security updates. I.e. I think the other two security alerts we received should be dismissed (and maybe we configure dependabot to ignore those modules).

What Type of PR Is This?

/kind chore

Release Notes

[CVE-2026-24051] Bump opentelemetry SDK to v1.41.0

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. labels Mar 5, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mjudeikis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2026
@xrstf

xrstf commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

/label tide/merge-method-squash

@kcp-ci-bot kcp-ci-bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 5, 2026
@xrstf

xrstf commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

/retest

xrstf added 2 commits March 6, 2026 12:58
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf

xrstf commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

@xrstf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-shared 487b759 link true /test pull-kcp-test-e2e-shared
pull-kcp-test-e2e-sharded 487b759 link true /test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e 487b759 link true /test pull-kcp-test-e2e
pull-kcp-test-e2e-multiple-runs 487b759 link true /test pull-kcp-test-e2e-multiple-runs

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xrstf

xrstf commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I am now convinced that this is not a flake 😅

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrstf xrstf closed this Mar 13, 2026
@xrstf
xrstf deleted the bump-otel-sdk branch April 20, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants