Skip to content

add system:kcp:admin to front-proxy's kubeconfig cert - #297

Closed
iakmc wants to merge 1 commit into
kcp-dev:mainfrom
iakmc:frontproxy-cert-admin-group
Closed

iakmc wants to merge 1 commit into
kcp-dev:mainfrom
iakmc:frontproxy-cert-admin-group

Conversation

@iakmc

@iakmc iakmc commented Sep 20, 2026

Copy link
Copy Markdown

Summary

Front-proxy's kubeconfig client cert only had system:masters in its Subject Organizations. That's not enough to reach kcp's Admin Workspace (/services/admin), which front-proxy needs for shard discovery (NewPeersConfig in pkg/proxy/peers.go). The Admin Workspace authorizer checks for group membership in system:kcp:admin specifically, not system:masters, so front-proxy was getting denied there.

What Type of PR Is This?

/kind bug

Related Issue(s)

Part from this PR

Release Notes

front-proxy's kubeconfig client certificate now includes the `system:kcp:admin` group, fixing access to kcp's Admin Workspace used for shard discovery.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Sep 20, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2026
@iakmc

iakmc commented Sep 20, 2026

Copy link
Copy Markdown
Author

/test pull-kcp-operator-test-e2e-canary

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

@iakmc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-operator-test-e2e-canary 33ba0bb link false /test pull-kcp-operator-test-e2e-canary

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mjudeikis

Copy link
Copy Markdown
Contributor

I dont think we need this anymore?

@iakmc iakmc closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants