Repository navigation
remove the console and show what an offering serves in the catalog - #13
Closed
olamilekan000 wants to merge 1 commit into
Closed
olamilekan000 wants to merge 1 commit into
olamilekan000 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
olamilekan000
force-pushed
the
remove-console
branch
from
October 30, 2026 08:07
09ca573 to
ef2322a
Compare
The console now lives in kcp hub, which runs tenancy and the marketplace as one platform, so ui/ goes, with what only it used: its Tilt resources, its .gitignore entries, and dex's CORS origins and redirect URIs for the vite dev server. Comments and docs that described its behaviour are reworded or dropped. A catalog entry said who published an API and what it claims, but not what the API is. Consumers had to enable an offering to learn its schema, and the platform admin could not see it at all without read access to the producer's workspace. marketplace-publish now also claims read on apiresourceschemas. The directory mirrors the schemas an export references, the same way it mirrors instructions, and joins them at read time, so every CatalogOffering carries a resources list: group, resource, kind, scope, and each version's OpenAPI schema verbatim. A binding accepted before this keeps the claims it had. Its offerings still list their resources, without versions, until the producer accepts the new claim. Signed-off-by: olamilekan000 <odukoyaonline@gmail.com>
olamilekan000
force-pushed
the
remove-console
branch
from
October 30, 2026 08:55
ef2322a to
61f47f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes for kcp hub, which now runs tenancy and the marketplace as one platform with its own console.
Remove the console
ui/moves to kcp hub, so it goes from here along with what only it used:.gitignoreentries;localhost:5173-5175redirect URIs for the vite dev server (contribctl login's loopback URI stays);Show what an offering serves in the catalog
A catalog entry said who published an API and what it claims, but not what the API is. Consumers had to enable an offering to learn its schema, and the platform admin could not see it without read access to the producer's workspace.
marketplace-publishalso claimsget, list, watchonapis.kcp.io/apiresourceschemas.CatalogOfferinggainsresources: group, resource, schema name, kind, scope, and each version's OpenAPI schema verbatim.A binding accepted before this keeps its claims. Its offerings still list their resources, without versions, until the producer accepts the new claim. kcp hub's console prompts for that on its Publish page.
Testing
go build,go vetandgo test ./marketplace/pkg/..., including a new directory test for the join: an unseen schema is listed without versions, and a schema of the same name in another workspace is not joined.make test-e2e-marketplace) has not been run;acceptedPublishClaimsthere includes the new claim.