Skip to content

remove the console and show what an offering serves in the catalog - #13

Closed
olamilekan000 wants to merge 1 commit into
kcp-dev:marketplace.vwfrom
olamilekan000:remove-console
Closed

olamilekan000 wants to merge 1 commit into
kcp-dev:marketplace.vwfrom
olamilekan000:remove-console

Conversation

@olamilekan000

@olamilekan000 olamilekan000 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Two changes for kcp hub, which now runs tenancy and the marketplace as one platform with its own console.

Remove the console

ui/ moves to kcp hub, so it goes from here along with what only it used:

  • its Tilt resources and .gitignore entries;
  • dex's CORS origins and the localhost:5173-5175 redirect URIs for the vite dev server (contribctl login's loopback URI stays);
  • comments and docs describing the console's own behaviour, reworded or dropped. Mentions of "the console" as whatever shows a producer's instructions stay, since that is still true.

Show what an offering serves in the catalog

A catalog entry said who published an API and what it claims, but not what the API is. Consumers had to enable an offering to learn its schema, and the platform admin could not see it without read access to the producer's workspace.

  • marketplace-publish also claims get, list, watch on apis.kcp.io/apiresourceschemas.
  • The provider mirrors the schemas exports reference into the directory, like instructions, and joins them at read time.
  • CatalogOffering gains resources: group, resource, schema name, kind, scope, and each version's OpenAPI schema verbatim.

A binding accepted before this keeps its claims. Its offerings still list their resources, without versions, until the producer accepts the new claim. kcp hub's console prompts for that on its Publish page.

Testing

  • go build, go vet and go test ./marketplace/pkg/..., including a new directory test for the join: an unseen schema is listed without versions, and a schema of the same name in another workspace is not joined.
  • Deployed in kcp hub against a provisioned producer and an external one: schemas show in the catalog once the claim is accepted, and resources without versions before.
  • The marketplace e2e suite (make test-e2e-marketplace) has not been run; acceptedPublishClaims there includes the new claim.

@kcp-ci-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olamilekan000 olamilekan000 changed the title remove the console, now in kcp hub Remove the console and show what an offering serves in the catalog Oct 30, 2026
@olamilekan000 olamilekan000 changed the title Remove the console and show what an offering serves in the catalog remove the console and show what an offering serves in the catalog Oct 30, 2026
The console now lives in kcp hub, which runs tenancy and the marketplace
as one platform, so ui/ goes, with what only it used: its Tilt
resources, its .gitignore entries, and dex's CORS origins and redirect
URIs for the vite dev server. Comments and docs that described its
behaviour are reworded or dropped.

A catalog entry said who published an API and what it claims, but not
what the API is. Consumers had to enable an offering to learn its
schema, and the platform admin could not see it at all without read
access to the producer's workspace.

marketplace-publish now also claims read on apiresourceschemas. The
directory mirrors the schemas an export references, the same way it
mirrors instructions, and joins them at read time, so every
CatalogOffering carries a resources list: group, resource, kind, scope,
and each version's OpenAPI schema verbatim.

A binding accepted before this keeps the claims it had. Its offerings
still list their resources, without versions, until the producer
accepts the new claim.

Signed-off-by: olamilekan000 <odukoyaonline@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants