Repository navigation
Move platform metadata off *.kcp.io and fix CLI, tilt and console rough edges - #11
Merged
Merged
Conversation
olamilekan000
commented
Oct 21, 2026
olamilekan000
commented
- Rename tenancy.platform.kcp.io/owner-uid to tenancy.kcp.hub/owner-uid and marketplace.platform.kcp.io/* to marketplace.kcp.hub/*, since kcp's ReservedMetadata admission rejects *.kcp.io keys from non-system callers
- Update example and quickstart APIExports and READMEs for the new keys
- contribctl offers and enable fall back to the token cached by login
- Tilt operators wait for ingress-forward so they no longer exit before kcp is reachable
- Tilt seeds with contribctl admin seed
- Console Admin page can register a provisioned Producer, with name validation
- API Explorer skips listing kinds that cannot be listed
- Catalog explains how to publish an API when it is empty
- Clearer subtitles on the API Explorer and Catalog pages
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
olamilekan000
force-pushed
the
marketplace.vw
branch
from
October 21, 2026 23:20
78689ab to
54bd893
Compare
…h edges - Rename tenancy.platform.kcp.io/owner-uid to tenancy.kcp.hub/owner-uid and marketplace.platform.kcp.io/* to marketplace.kcp.hub/*, since kcp's ReservedMetadata admission rejects *.kcp.io keys from non-system callers - Update example and quickstart APIExports and READMEs for the new keys - tenancy and marketplace init update their RBAC in place, so restarts no longer fail the reserved-metadata check on internal.kcp.io annotations - tenancy and marketplace init grant a narrow platform-admin role (--platform-admin-user/--platform-admin-group); Tilt adds the admin@platform.example.com dex user as platform admin - contribctl offers and enable fall back to the token cached by login - Tilt operators wait for ingress-forward before starting - Tilt seeds with contribctl admin seed - Console Admin page registers Producers, shown only to those allowed - API Explorer skips listing kinds that cannot be listed - Catalog explains how to publish an API when it is empty - Return the server error on shutdown instead of dropping it (errcheck) - Remove committed vitest cache and tsbuildinfo, and ignore them - make test-e2e includes marketplace Signed-off-by: olamilekan000 <odukoyaonline@gmail.com>
olamilekan000
force-pushed
the
marketplace.vw
branch
from
October 21, 2026 23:37
54bd893 to
c7d563a
Compare
mjudeikis
reviewed
Oct 22, 2026
| // naming candidates, and how a collision with someone else's workspace is | ||
| // told apart from an earlier run of the same reconcile. | ||
| const ownerUIDLabel = tenancyv1alpha1.GroupName + "/owner-uid" | ||
| const ownerUIDLabel = "tenancy.kcp.hub/owner-uid" |
Contributor
There was a problem hiding this comment.
Lets move into api please
mjudeikis
approved these changes
Oct 22, 2026
mjudeikis
left a comment
mjudeikis
left a comment
Contributor
There was a problem hiding this comment.
one nit. can be done in follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.