Skip to content

allow to set $DEBUG_BUILD to build a binary with debugging symbols - #92

Merged
kcp-ci-bot merged 1 commit into
mainfrom
enable-debugging
Sep 18, 2025
Merged

kcp-ci-bot merged 1 commit into
mainfrom
enable-debugging

Conversation

@xrstf

@xrstf xrstf commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Summary

This makes it much easier to use debuggers to connect to an agent. Simply build with DEBUG_BUILD=1 make and bam, done.

What Type of PR Is This?

/kind feature

Release Notes

NONE

…cluded and paths not trimmed

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2025
@xrstf
xrstf requested a review from embik September 16, 2025 18:18
@mirzakopic mirzakopic moved this from In Progress to Blocked/Waiting in Platform Mesh & Kube Projects - Backlog Sep 17, 2025

@embik embik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: cb60e6a78da09e0c9c69fa548cfd14ffb0bcb32c

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
@embik

embik commented Sep 18, 2025

Copy link
Copy Markdown
Member

/retest

pretty, please, merge?

@kcp-ci-bot
kcp-ci-bot merged commit 4966fa5 into main Sep 18, 2025
11 checks passed
@kcp-ci-bot
kcp-ci-bot deleted the enable-debugging branch September 18, 2025 09:56
@github-project-automation github-project-automation Bot moved this from Blocked/Waiting to Done in Platform Mesh & Kube Projects - Backlog Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants