[Sarthak-Shreshtha01]

Summary

The cancel function of a new sync controller was saved before the controller was started. If the start failed, the saved entry made every later retry exit early, so the controller never started. Now the entry is saved only after a successful start. I added TestStartAndRecord for this.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #190

Release Notes

Fix a failed sync controller start blocking later start retries.

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrstf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kcp-ci-bot]

Hi @Sarthak-Shreshtha01. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.