fix: link valid stream insertion return values - #75
Merged
Conversation
The bundled WASI libc++abi lacks the __cxa exception runtime. Disable exceptions by default so valid stream insertion of function return values links successfully, and cover it in the browser smoke test.
Exercise the bundled Clang and LLD artifacts for defined stream return values and expected undefined user symbols, and force the unsupported exception flag off after user options.
Fetch the WASM toolchain in CI and execute the stream-insertion compiler E2E, including a real WASI run of the linked binary.
Explain the no-exception toolchain limitation and release version 0.4.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__cxa_*symbols.intandstd::stringreturn values streamed throughstd::cout.try,catch, andthroware unavailable in the bundled toolchain, and bump the extension version to0.4.6.Verification
npm run lintnpm run test:e2e:compilernpm run buildnpm run test:e2enpm run test:browser:chrome(artifact-aware compiler E2E passed; the browser subprocess did not emit a completion line through this environment's runner)Closes #74