move AZS005, AZS006, AZS008, AZR005 into the AZP category as AZP002-AZP005 - #48
Merged
Merged
Conversation
katbyte
force-pushed
the
kt/azp-moves
branch
from
September 24, 2026 23:21
6c43bf4 to
f56b421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking. Moves four rules into the AZP category (added in #47):
AZS005→AZP002,AZS006→AZP003,AZS008→AZP004,AZR005→AZP005.Why: AZS rules are about one schema and AZR rules about one resource. These four check the provider as a whole: every resource has a data source, each data source exposes its resource's properties, the registration lists are sorted, and a provider-wide feature flag stays unset. That is what AZP is for. Renaming gets more expensive with every
//azignore:comment written against the old names, so it should ship before azurerm next upgrades.The rules move, the checks don't change. The folders were moved with
git mv. The rule names, flag prefixes, URLs, test packages and READMEs now use the new names. The AZP section now sits under AZG in the README.Old names that main added after this PR was first written. #49 added a second AZS005 test package, an
//azignore:AZS006in an AZS006 test file, and an "as in AZS005" in a README. The test package would have been left behind in the old folder. With the old name still in place, the ignore comment stopped working, soTestAZP003failed. All three now use the new names.What azurerm has to change. azurerm is pinned to v0.8.0. Its
.golangci.ymlturns offAZS005andAZS006by name, and it has four//azignore:AZS006comments (servicebus queue and topic, signalr, traffic manager). The plugin rejects rule names it doesn't know, so the upgrade fails loudly until those six lines are renamed. The rules can't quietly turn back on.Things that are fine as they are.
==) is the closest call. It is about resource IDs, so it stays in AZR.Tests and lint pass on top of main.