Fix INET/CIDR column scan through pgtxdb buffer#31
Open
miyataka wants to merge 1 commit into
Open
Conversation
pgx returns inet/cidr values as string when scanning into interface{},
losing the type information needed for database/sql to convert to
netip.Prefix. Preserve column type names from ColumnTypes() and convert
string values back to netip.Prefix for INET/CIDR columns in rows.Next().
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stringfor INET/CIDR columns when scanning intointerface{}, losing type info in pgtxdb's intermediate row bufferDatabaseTypeName()fromColumnTypes()in therowsstruct, and convertstring→netip.Prefixfor INET/CIDR columns inNext()ParsePrefixfirst, falls back toParseAddr+PrefixFrom(addr, addr.BitLen())for bare addressesParsePrefixBackground
When pgtxdb buffers rows via
rows.read(), all values are scanned intointerface{}. pgx returns INET/CIDR asstringin this case, unlike when scanning directly into*netip.Prefix. The downstreamdatabase/sql.Scanthen fails because it cannot convertstringto*netip.Prefix.Test plan
TestInetScancovers IPv4 INET, CIDR, and IPv6 INET round-trip through pgtxdb🤖 Generated with Claude Code